When using 'infiniteScrollContainer' attribute the calculation isn't according to the chosen container#377
Open
Michaelzvu wants to merge 1 commit intosroze:masterfrom
Conversation
…ative to the container. So I fix it to be relative to the chosen container.
|
@Michaelzvu This project currently assumes that the element you put the attributes on is the element you want to use to calculate/compare with the container. I've made a change so that you can target a different "list" element as well as the feature you're trying to use to target a specific "container" element. I need to clean my change up and test it a little more but IMO it's a bug/missing feature. #384 is the fix PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#376
While the container isn't the windowElement the calculation isn't relative to the container.
So I fix it to be relative to the chosen container.