Use base64 encoding to support dump and import binary data#9
Open
gengmao wants to merge 2 commits intosroegner:masterfrom
Open
Use base64 encoding to support dump and import binary data#9gengmao wants to merge 2 commits intosroegner:masterfrom
gengmao wants to merge 2 commits intosroegner:masterfrom
Conversation
|
@gengmao This worked like a charm - Thanks! |
|
I love you. Also, who cares if the data isn't readable anymore: I shat my pants when our dumps didn't import correctly. 🍻 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some of my zookeeper nodes have binary data. When I dumped them out and import back, I hit following exception.
Then I studied source code and #7, found the binary data was not processed correctly. As the dump file is only parsed as text file when import, the binary data need to be encoded in a revertible text format, for example base64.
With this PR, multi-lines node data can be imported too. Just one drawback - node data in the dump file are not readable any more.