Add an "add to calendar" button to event pages#486
Add an "add to calendar" button to event pages#486RealOrangeOne wants to merge 12 commits intomainfrom
Conversation
|
Do we have any control over the styling? That box is rather different to the way we generally style things. |
|
Can we make it not blur the entire page when hovered over? Not sure why we'd want to obscure the information about the event just because a user is potentially about to add it to their calendar. Also it seems to respect the system theme which while cool means I have a black button in the blue header when we should probably just force it to be white |
This matches the rest of the site's styling
This works better
It's not perfect, but it's a lot better
sedders123
left a comment
sedders123
left a comment
There was a problem hiding this comment.
When the dropdown is open the mouse cursor is changed to an SVG, can we keep the default cursor please. Also can we reduce the border on .atcb-list to be 1px rather than the 0.15em it is now.
Also not a fan of the checkmark that is displayed once the user clicks an option within the dropdown
could we please remove this?
Do we actually need a third party dependency for this functionality? A dropdown with links to add our calendar to those providers could be much more lightweight for us to implement ourselves. We don't seem to want the majority of the features this component provides. (Also, personally, I'm mildly irritated at how this component uses JS to open links rather than <a> tags. Means you can't middle click to open in new tab, yes left clicking does open in a new tab but it breaks my assumptions as a user of the web)
|
On mobile I think it'd be nice if this displayed inline with the content rather than causing the header to squish? Current
Proposed (Excuse slightly jank mockup)
|
|
Or, riffing off what James proposed, maybe just putting this as a new line at the bottom of the date/location block could work? That way it has a natural home on mobile too: |
3 participants
This adds an "Add to calendar" button to the events list and event page. The buttons always try to embed the full event list, rather than just adding the single event. It's a little misleading, but it ensures the person sees all our future events too.