refactor: Simplify and clean up Haskell codebase#175
Draft
Conversation
- Extract duplicated lock pattern in Dynamic.hs into lockedUpdate/keepAlive helpers - Unify duplicate FromMaybe type family (Generic.hs → Symbol.hs) - Simplify decodeUrlRoute using `first` over Either - Replace if-then-else with when/unless/unlessM where clearer - Remove dead commented-out code in Prism/Check.hs - Extract duplicated REDIRECT message in WebSocket.hs - Clean up redundant imports, parens, and intermediate bindings - Fix typos: isomoprhic, isomporphic, tyupe - Rewrite FromJSON UrlStrategy with explicit case matching
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Code elegance pass across the codebase, generated using the
/elegancecommand.Dynamic.hsintolockedUpdate/keepAlivehelpersFromMaybetype family (remove fromGeneric.hs, export fromSymbol.hs)decodeUrlRouteusingfirstoverEitherinstead of manual case matchingif-then-elsewithwhen/unless/unlessMwhere clearerPrism/Check.hsREDIRECTmessage inWebSocket.hsisomoprhic,isomporphic,tyupeFromJSON UrlStrategywith explicitcasematching and proper error messageTest plan
nix run github:juspay/vira -- ci -bpasses