PEAR/Squiz/[MultiLine]FunctionDeclaration: allow for PHP 8.1 new in initializers#3787
Merged
gsherwood merged 1 commit intosquizlabs:masterfrom May 4, 2023
Conversation
…nitializers Since PHP 8.1, `new ClassName()` expressions can be used as the default value of a parameter in a function declaration. `new ClassName()` expressions should be treated as function _calls_, which have their own indentation rules, so the `PEAR.Functions.FunctionDeclaration` and the `Squiz.Functions.MultiLineFunctionDeclaration` sniffs should skip over these and not attempt to change the indentation of parameters in those function calls. This commit implements this change. Includes unit tests. Refs: * https://wiki.php.net/rfc/new_in_initializers * https://www.php.net/manual/en/migration81.new-features.php#migration81.new-features.core.new-in-initializer * https://www.php.net/manual/en/language.oop5.decon.php#language.oop5.decon.constructor.new Fixes 3786
Contributor
Author
jrfnl
deleted the
feature/3786-squiz/multilinefunctiondeclarations-allow-for-new-in-initializers
branch
Contributor
Author
|
FYI: this fix is included in today's PHP_CodeSniffer 3.8.0 release. As per #3932, development on PHP_CodeSniffer will continue in the PHPCSStandards/PHP_CodeSniffer repository. If you want to stay informed, you may want to start "watching" that repo (or watching releases from that repo). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since PHP 8.1,
new ClassName()expressions can be used as the default value of a parameter in a function declaration.new ClassName()expressions should be treated as function calls, which have their own indentation rules, so thePEAR.Functions.FunctionDeclarationand theSquiz.Functions.MultiLineFunctionDeclarationsniffs should skip over these and not attempt to change the indentation of parameters in those function calls.This commit implements this change.
Includes unit tests.
Refs:
Fixes #3786
Note:
File::getMethodParameters()method handles "new in initializers" correctly.Squiz.Functions.FunctionDeclaration, theSquiz.Functions.FunctionDeclarationArgumentSpacingand thePSR2.Methods.MethodDeclarationsniffs, I don't foresee that those need changes for "new in initializers".