Workarounds for null dereference bugs#10
Open
carolhanna01 wants to merge 1 commit intosquaresLab:masterfrom
Open
Workarounds for null dereference bugs#10carolhanna01 wants to merge 1 commit intosquaresLab:masterfrom
carolhanna01 wants to merge 1 commit intosquaresLab:masterfrom
Conversation
clegoues
reviewed
Apr 5, 2024
Contributor
clegoues
left a comment
clegoues
left a comment
There was a problem hiding this comment.
Hi Carol! Sorry for the slow handling of these, ha. I'm inclined to just accept these, but I'm wondering if you did any digging into why any of these things MIGHT return null? Or if there's example code you have where you know it happens?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've encountered some null dereference issues while running some longer experiments. I added some null safety checks that prevent the search from prematurely terminating due to the null exceptions that get thrown. These are not root-cause fixes, just workarounds that enabled us to run the search to completion. I hope that this can help pinpoint the underlying issues!