Skip to content

Add index definition schema intellisense #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andrewmumblebee merged 1 commit into from
Jun 22, 2026
Merged

Add index definition schema intellisense #70

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
64 changes: 34 additions & 30 deletions .vscode/settings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,32 +1,36 @@
{
"json.schemas": [
{
"fileMatch": ["**/dataStreams/*.json"],
"url": "https://schemas.squaredup.com/schemas/latest/datastream.schema.json"
},
{
"fileMatch": ["**/metadata.json"],
"url": "https://schemas.squaredup.com/schemas/latest/metadata.schema.json"
},
{
"fileMatch": ["**/configValidation.json"],
"url": "https://schemas.squaredup.com/schemas/latest/configValidation.schema.json"
},
{
"fileMatch": ["**/defaultContent/**/*.dash.json"],
"url": "https://schemas.squaredup.com/schemas/latest/defaultContent.schema.json"
},
{
"fileMatch": ["**/defaultContent/**/manifest.json"],
"url": "https://schemas.squaredup.com/schemas/latest/manifest.schema.json"
},
{
"fileMatch": ["**/defaultContent/scopes.json"],
"url": "https://schemas.squaredup.com/schemas/latest/scopes.schema.json"
},
{
"fileMatch": ["**/ui.json"],
"url": "https://schemas.squaredup.com/schemas/latest/ui.schema.json"
}
]
"json.schemas": [
{
"fileMatch": ["**/dataStreams/*.json"],
"url": "https://schemas.squaredup.com/schemas/latest/datastream.schema.json"

Check warning on line 5 in .vscode/settings.json

View check run for this annotation

Claude / Claude Code Review

Whole-file indentation churn unrelated to the fix 

The diff re-indents the entire file from 2-space to 4-space indentation, turning a 4-line addition (the new `indexDefinitions` schema entry) into a 32-line diff where every existing line is touched. Per REVIEW.md's guidance to 'Keep diffs focused and minimal' and 'Follow existing formatting in the repo', revert the indentation change and add only the new schema block at the existing 2-space indent.
Comment thread
clarkd marked this conversation as resolved.
},
{
"fileMatch": ["**/metadata.json"],
"url": "https://schemas.squaredup.com/schemas/latest/metadata.schema.json"
},
{
"fileMatch": ["**/indexDefinitions/*.json"],
"url": "https://schemas.squaredup.com/schemas/latest/importDefinition.schema.json"
},
{
"fileMatch": ["**/configValidation.json"],
"url": "https://schemas.squaredup.com/schemas/latest/configValidation.schema.json"
},
{
"fileMatch": ["**/defaultContent/**/*.dash.json"],
"url": "https://schemas.squaredup.com/schemas/latest/defaultContent.schema.json"
},
{
"fileMatch": ["**/defaultContent/**/manifest.json"],
"url": "https://schemas.squaredup.com/schemas/latest/manifest.schema.json"
},
{
"fileMatch": ["**/defaultContent/scopes.json"],
"url": "https://schemas.squaredup.com/schemas/latest/scopes.schema.json"
},
{
"fileMatch": ["**/ui.json"],
"url": "https://schemas.squaredup.com/schemas/latest/ui.schema.json"
}
]
}
Loading