Refactor WorkflowNode into AbstractWorkflowNode <- StatefulWorkflowNode.#1356
Draft
zach-klippenstein wants to merge 2 commits intomainfrom
Draft
Refactor WorkflowNode into AbstractWorkflowNode <- StatefulWorkflowNode.#1356zach-klippenstein wants to merge 2 commits intomainfrom
zach-klippenstein wants to merge 2 commits intomainfrom
Conversation
zach-klippenstein
force-pushed
the
zachklipp/workflownode-poly
branch
2 times, most recently
from
ddf7e1c to
88c9beb
Compare
This is to prepare for go/compose-based-workflows.
This intermediate rename was to help git show the correct history for StatefulWorkflowNode.
zach-klippenstein
force-pushed
the
zachklipp/workflownode-poly
branch
from
b4e82d7 to
05cad44
Compare
Collaborator
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to prepare for go/compose-based-workflows.
This is two commits to make git diff recognize the extracted abstract class as the new file instead of the
WorkflowNode -> StatefulWorkflowNoderename. However, github doesn't get this and showsStatefulWorkflowNodeas a net new file, so it's must easier to review if you only look at the first commit.