Skip to content

Make the bindService method final #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
clamothebb wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Make the bindService method final #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion server-generator/src/main/java/com/squareup/wire/kotlin/grpcserver/ImplBaseGenerator.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ object ImplBaseGenerator {

builder.addFunction(
FunSpec.builder("bindService")
.addModifiers(KModifier.OVERRIDE)
.addModifiers(KModifier.OVERRIDE, KModifier.FINAL)
.returns(ClassName("io.grpc", "ServerServiceDefinition"))
.addCode(bindServiceCodeBlock(service, options))
.build(),
Expand Down
2 changes: 1 addition & 1 deletion server-generator/src/test/golden/ImplBase.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ public class RouteGuideWireGrpc {
public open fun RouteChat(response: StreamObserver<RouteNote>): StreamObserver<RouteNote> =
throw UnsupportedOperationException()

override fun bindService(): ServerServiceDefinition =
final override fun bindService(): ServerServiceDefinition =
ServerServiceDefinition.builder(getServiceDescriptor()).addMethod(
getGetFeatureMethod(),
asyncUnaryCall(this@RouteGuideImplBase::GetFeature)
Expand Down
2 changes: 1 addition & 1 deletion server-generator/src/test/golden/RouteGuideWireGrpc.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,7 @@ public object RouteGuideWireGrpc {
public open fun RouteChat(response: StreamObserver<RouteNote>): StreamObserver<RouteNote> =
throw UnsupportedOperationException()

override fun bindService(): ServerServiceDefinition =
final override fun bindService(): ServerServiceDefinition =
ServerServiceDefinition.builder(getServiceDescriptor()).addMethod(
getGetFeatureMethod(),
serverCallsAsyncUnaryCall(this@RouteGuideImplBase::GetFeature)
Expand Down
2 changes: 1 addition & 1 deletion server-generator/src/test/golden/nonSingleMethodService.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ public object FooServiceWireGrpc {
public open fun Call2(request: Request, response: StreamObserver<Response>): Unit = throw
UnsupportedOperationException()

override fun bindService(): ServerServiceDefinition =
final override fun bindService(): ServerServiceDefinition =
ServerServiceDefinition.builder(getServiceDescriptor()).addMethod(
getCall1Method(),
serverCallsAsyncUnaryCall(this@FooServiceImplBase::Call1)
Expand Down
2 changes: 1 addition & 1 deletion server-generator/src/test/golden/singleMethodService.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ public object FooServiceWireGrpc {
public open fun Call2(request: Request, response: StreamObserver<Response>): Unit = throw
UnsupportedOperationException()

override fun bindService(): ServerServiceDefinition =
final override fun bindService(): ServerServiceDefinition =
ServerServiceDefinition.builder(getServiceDescriptor()).addMethod(
getCall1Method(),
serverCallsAsyncUnaryCall(this@FooServiceImplBase::Call1)
Expand Down
2 changes: 1 addition & 1 deletion server-generator/src/test/golden/unitService.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ public object MyServiceWireGrpc {
) : WireBindableService {
public open suspend fun doSomething(request: Unit): Unit = throw UnsupportedOperationException()

override fun bindService(): ServerServiceDefinition =
final override fun bindService(): ServerServiceDefinition =
ServerServiceDefinition.builder(getServiceDescriptor()).addMethod(
io.grpc.kotlin.ServerCalls.unaryServerMethodDefinition(
context = context,
Expand Down