Ensure openInputStream cannot kill calling process#2340
Open
herriojr wants to merge 1 commit intosquare:masterfrom
Open
Ensure openInputStream cannot kill calling process#2340herriojr wants to merge 1 commit intosquare:masterfrom
herriojr wants to merge 1 commit intosquare:masterfrom
Conversation
This addresses issue square#2339 ContentResolver.openInputStream falls back to using a stable content provider which will kill the main process if it fails. Never trust an external process as there may be many things that might cause this such as reinstalls, application updates, etc. Fall back to a FileNotFoundException.
Author
|
@nathanmeade Apparently I don't have enough privs to do so? I can't modify the reviewers here like I can with other projects I work on. |
|
@herriojr I looked around for the contributing guidelines and I found this: (from: https://square.github.io/picasso/) After all of the above is squared away my best guess would be to try to ping the most recent reviewers of the PRs (jrodbx, afollestad,...) |
Author
|
@nathanmeade all that was completed before I bother with the pull request. |
Author
|
@jrodbx any input on this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses issue #2339
ContentResolver.openInputStream falls back to using a stable content provider which will kill the main process if it fails. Never trust an external process as there may be many things that might cause this such as reinstalls, application updates, etc. Fall back to a FileNotFoundException.