onlyScaleDown() compatibility with fit()#1623
Open
magneticflux- wants to merge 4 commits intosquare:masterfrom
Open
onlyScaleDown() compatibility with fit()#1623magneticflux- wants to merge 4 commits intosquare:masterfrom
magneticflux- wants to merge 4 commits intosquare:masterfrom
Conversation
…eferred resize() call can have onlyScaleDown() called after it
…() or resize() called beforehand
…ypes when it was intentionally provided as invalid
…od that it actually calls
Author
|
@JakeWharton Friendly ping! 😃 |
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #941
This pull request adds a boolean flag that is used to identify if calling
onlyScaleDownwas requested. When the fit() call resizes the request, thedoOnlyScaleDownboolean flag is checked and theonlyScaleDownmethod may be called.I also performed minor changes in the test file that I modified, namely adding error suppression for obviously intentional lines of code.
I have accepted the Square CLA.