Fix pauseTags Leak with pauseTag()/resumeTag()/cancelTag()#1601
Open
kwangsu61 wants to merge 2 commits intosquare:masterfrom
Open
Fix pauseTags Leak with pauseTag()/resumeTag()/cancelTag()#1601kwangsu61 wants to merge 2 commits intosquare:masterfrom
kwangsu61 wants to merge 2 commits intosquare:masterfrom
Conversation
…e for Dispatcher’s performRemoveTag()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If tag methods are called in the following order (ex. according to Activity Lifecycle)
resumeTag("TAG") => pauseTag("TAG") => cancelTag("TAG")
"Set pausedTags" in Dispatcher class still have tag object after cancelTag().
If tag is activity, activity leak occurs.
So I added to remove tag in pausedTags when cancelTag() is called.
Thanks