Add conveniences to size an image view preserving its image's aspect ratio #137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfed
approved these changes
Aug 30, 2024
Collaborator
dfed
left a comment
dfed
left a comment
There was a problem hiding this comment.
that'll save me some typing!
| /// Returns the largest size that will fit within the specified available `width` and `height`, preserving the receiver's `image`'s aspect ratio. | ||
| /// | ||
| /// If `allowUpscaling` is true, the returned size will be at most the image's native size. This is most commonly used when the `image` is a raster image and is not meant to be scaled up. | ||
| public func sizeThatFitsPreservingAspectRatio(width: CGFloat, height: CGFloat = .greatestFiniteMagnitude, allowingUpscaling: Bool) -> CGSize { |
Collaborator
There was a problem hiding this comment.
is this technically maxWidth and maxHeight?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #135