Conversation
pavshka
reviewed
Jan 13, 2025
| case v | ||
| when Array | ||
| v.map { |e| "#{url_encode(k.to_s)}[]=#{url_encode(e.to_s)}" }.join('&') | ||
| v.map { "#{url_encode(k.to_s)}[]=#{url_encode(_1.to_s)}" } |
There was a problem hiding this comment.
we can use it instead of _1 when upgraded to ruby 3.4.0:
https://www.ruby-lang.org/en/news/2024/12/25/ruby-3-4-0-released/
Contributor
There was a problem hiding this comment.
That would force the users to upgrade to at least Ruby 3.4.x as well though if they use this gem. That's a breaking change without any real benefits.
There was a problem hiding this comment.
yep, you're right, we would need to bump dependencies for that, which definitely does not make any sense.
so, please, ignore my comment above 🙈
Contributor
There was a problem hiding this comment.
For the internal codebase, valid comment, though :-)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our API supports
payment_methodoption, this PR adds an ability to pass it to the request. BothSquake::PricingandSquake::CalculationWithPricingdo support that option.This PR is also fixes the way we generate URL query params,
before:
/v2/pricing?product=product_026c41&¤cy=EUR&carbon_quantity=1000&carbon_unit=kilogram&&after:
/v2/pricing?product=product_026c41¤cy=EUR&carbon_quantity=1000&carbon_unit=kilogram