Fix typing of partial_reordering#1764
Conversation
sqla-tester
left a comment
There was a problem hiding this comment.
OK, this is sqla-tester setting up my work on behalf of zzzeek to try to get revision afd9a70 of this pull request into gerrit so we can run tests and reviews and stuff
|
New Gerrit review created for change afd9a70: https://gerrit.sqlalchemy.org/c/sqlalchemy/alembic/+/6521 |
zzzeek
left a comment
There was a problem hiding this comment.
I think these Any are strings, we can use newer style annotations now also
sqla-tester
left a comment
There was a problem hiding this comment.
OK, this is sqla-tester setting up my work on behalf of zzzeek to try to get revision f0a0c1a of this pull request into gerrit so we can run tests and reviews and stuff
|
Patchset f0a0c1a added to existing Gerrit review https://gerrit.sqlalchemy.org/c/sqlalchemy/alembic/+/6521 |
|
Michael Bayer (zzzeek) wrote: our tooling does not support the View this in Gerrit at https://gerrit.sqlalchemy.org/c/sqlalchemy/alembic/+/6521 |
|
Gerrit review https://gerrit.sqlalchemy.org/c/sqlalchemy/alembic/+/6521 has been merged. Congratulations! :) |
The typing of the
partial_reorderingargument ofbatch_alter_tableis not correct.Description
As stated in the documentation and docstring, the
batch_alter_table()function expects a list of tuples for thepartial_reorderingargument. The current typing suggests the user to insert a tuple containing Any into the argument, which doesn't align with the docstring.Checklist
This pull request is:
must include a complete example of the issue. one line code fixes without an
issue and demonstration will not be accepted.
Fixes: #<issue number>in the commit messageinclude a complete example of how the feature would look.
Fixes: #<issue number>in the commit messageHave a nice day!