Conversation
sbihel
approved these changes
Mar 19, 2026
Member
sbihel
left a comment
There was a problem hiding this comment.
Looks good. I don't know why it wasn't already the case but these changes make sense.
Now, if you encounter cache misses, it's probably because the cache limit of 10GB is too little. We can increase it if need be.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Looks like we are never using Rust Cache, since the executable never finds
Cargo.toml. This PR fixes the target folder used by rust_cache in CI/CD.You can check any previous CI: https://github.com/spruceid/sprucekit-mobile/actions/runs/23024537471/job/66869108375#step:4:23 to see the error. And compare with the same step in this PR's CI.
Error: