Closed
Conversation
Signed-off-by: Ryan Tate <ryan.tate@spruceid.com>
Signed-off-by: Ryan Tate <ryan.tate@spruceid.com>
…data - add Oid4vpVersion and get_oid4vp_version to the Rust OID4VP API - add Rust tests covering v1, draft-18, ambiguous, and unsupported request shapes - expose draft-18 input_descriptor_id and selective_disclosable on presentable credentials - update Android showcase to use Rust version detection and direct draft-18 descriptor grouping - update iOS showcase to use Rust version detection and direct draft-18 descriptor grouping - add draft-18 native signer/support flows for showcase apps - regenerate Kotlin and Swift UniFFI bindings for the new Rust API - remove duplicated native OID4VP request detector implementations
Contributor
Author
|
Closing in favor of #295 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds backward compatibility support for the OpenID for Verifiable Presentations (OID4VP) draft 18 specification to the Rust codebase. It introduces a self-contained
draft18module underoid4vpwith prior error handling, credential presentation, request signing, and delegated verification capabilities. The changes also update dependencies to include the appropriate version of the OID4VP library for draft 18.OID4VP Draft 18 Integration:
draft18module underoid4vp, exposing submodules for credential handling, error management, holder logic, permission requests, presentations, request signing, and verifier functionality. This module is now available for use throughout the codebase. [1] [2]Error Handling:
Draft18OID4VPErrorenum to provide detailed error reporting for all operations in the OID4VP draft 18 flow, including validation, token creation, submission, and cryptographic operations.Credential Presentation and Signing:
CredentialPresentationtrait and related types to define how credentials are presented, matched against definitions, and signed. Added theDraft18PresentationSignerinterface for host environments to provide signing capabilities, and theDraft18PresentationOptionsstruct to encapsulate presentation metadata and signing logic.Request Signing:
Draft18RequestSignerInterfacetrait and an example implementation for signing authorization requests, including error handling for unsupported algorithms and signing failures.Delegated Verification:
Draft18DelegatedVerifierobject and supporting types to initialize and poll the status of delegated verification requests, including structured responses and error handling for HTTP and URL issues.Dependency Update:
openidvp_draft18dependency toCargo.toml, pointing to the appropriate commit of the draft 18 implementation.