Skip to content

fix(ssh): bind ssh.task_definition to sshCmd's own flag #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SAY-5 wants to merge 1 commit into
base: master
Choose a base branch
from
+5 −1
Open

fix(ssh): bind ssh.task_definition to sshCmd's own flag #42

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion cmd/ssh.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,11 @@ var sshCmd = &cobra.Command{
func init() {
rootCmd.AddCommand(sshCmd)
sshCmd.PersistentFlags().StringP("task_definition", "t", "", "name of task definition to use (required)")
viper.BindPFlag("ssh.task_definition", runCmd.PersistentFlags().Lookup("task_definition"))
// Bind to sshCmd's own flag. runCmd does not define task_definition
// (its BindPFlag call is commented out), so the lookup returned a
// nil *pflag.Flag and any later viper.Get("ssh.task_definition")
// call panicked inside pflagValue.HasChanged.
viper.BindPFlag("ssh.task_definition", sshCmd.PersistentFlags().Lookup("task_definition"))

viper.SetDefault("ssh.push_ssh_key", true)
viper.SetDefault("ssh.task_definition", viper.GetString("task_definition"))
Expand Down