Dockerfile updates to add libffi-dev to resolve cffi dependancy errors #73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First test to create Docker image
V2 to add path to Dockerfile
V3 moving build context
V7 Rewrite to include push and caching
v9 - final single image build
Complete Script to build noble, alpine and slim images for the four main architectures
Added Build Date
r rebase instead of merge (cleaner history)
git rebase upstream/main
git push origin main
---
🧩 2. If you’re updating a submodule or external script repo inside your
project
You mentioned before that your Docker images depend on a script from
another Git repo — if you’ve added that as a submodule or use it as a
reference, use:
git submodule update --remote --merge
cd path/to/submodule
git fetch origin
git checkout main
git pull origin main
cd ..
git add path/to/submodule
git commit -m "Update submodule to latest upstream"
---
🔄 3. If you want to pull all branches/tags from upstream into your fork
git fetch upstream --prune
git checkout main
git merge upstream/main
git push origin main
git fetch upstream --tags
git push origin --tags
---
⚙️ 4. If you want to automate this in CI (like GitHub Actions)
Example snippet for your workflow YAML:
- name: Update from upstream
run: |
git remote add upstream https://github.com/ORIGINAL_OWNER/REPO.git
git fetch upstream
git checkout main
git merge upstream/main
git push origin main
---
Would you like me to tailor these commands to your
specific setup — e.g., the repo that builds Docker
images from another script repo — so that the
update triggers automatically when the upstream
changes?q
Contributor
|
this should fix springfall2008/batpred#2842 #70 |
Owner
|
Just reviewing this, I wonder if you can help updated?
|
Author
|
I think this was done before you made those changes Can we just reject this? I am not sure its required now we know that Home assistant is no longer going to support armv7 and unless I am missing them I am not seeing many issues with this any more. Also I don't want to add loads of commits to the main addon git. In the New year I am planning on making the Docker images more aligned with the home assistant addons and use s6 overlay so I may add some changes then |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if this did what I wanted, jus wanted to update Dockerfile & Dockerfile.standalone