GH-1587: Refactor fixTxOffsets to use ConsumerRecords#nextOffsets #4149
+284
−38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@bandalgomsu Thanks for the PR! Given our proximity to GA release, we'd prefer to defer this merge to avoid last-minute regressions. We'll revisit after next week's release. Meanwhile, could you add either a detailed commit message explaining the motivation or inline code comments? We'll also need tests to validate these changes. We need to make sure that the feedback that was given here is addressed adequately: #1587 (comment) |
Replaced the position()-based offset correction with nextOffsets() to address known issues with transactional topics: - Works correctly with both read_committed and read_uncommitted - Handles empty poll() advancement and leader epoch propagation - Fixes the case when max.poll.records equals transaction batch size Signed-off-by: Su Ko <rhtn1128@gmail.com>
Contributor
Author
|
Thanks for the comments !! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor fixTxOffsets to use nextOffsets API to correctly skip transactional commit markers
issue : #1587
thanks 🙂