Makes Nullability of findAll consistent. #4132
Open
+14
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All findAll methods now require a non null except one. Changing it to non-null would have been a breaking change since the implemented interface defines the Specificaton as nullable. Closes #4131
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All findAll methods now require a non null except one, matching the current implementation and documentation in the method comments.
Changing it to non-null would have been a breaking change since the implemented interface defines the Specificaton as nullable.
Of course, since there is a null check in place any actual call with a null parameter would already fail, and therefore we might accept this breakage.
Of course again, changing the methods to a non-null argument is technically also a breaking change since they might have been overwritten.
Closes #4131