Remove unnused parameter in ManifestLayerArchiveFactory#47694
Closed
Pankraz76 wants to merge 1 commit intospring-projects:mainfrom
Closed
Remove unnused parameter in ManifestLayerArchiveFactory#47694Pankraz76 wants to merge 1 commit intospring-projects:mainfrom
Pankraz76 wants to merge 1 commit intospring-projects:mainfrom
Conversation
Signed-off-by: Vincent Potucek <vpotucek@me.com>
7e870c0 to
c3c6e00
Compare
Pankraz76
commented
Oct 18, 2025
|
|
||
| private final Set<String> layers; | ||
|
|
||
| ManifestLayerArchiveFactory(Path tarFile, ImageArchiveManifest manifest) { |
Author
There was a problem hiding this comment.
is this important?
sometimes these unused fields relate to some kind of bug:
snicoll
pushed a commit
that referenced
this pull request
Oct 19, 2025
See gh-47694 Signed-off-by: Vincent Potucek <vpotucek@me.com>
2 tasks
This was referenced Nov 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related to:
RemoveUnused(Local)Parameter/RemoveUnusedParametersopenrewrite/rewrite-static-analysis#780