Adjust the priority of the configs#303
Open
woshikid wants to merge 1 commit intospring-cloud:3.1.xfrom
Open
Conversation
Author
|
@ryanjbaxter this PR does the same thing as spring-cloud/spring-cloud-config#2207 |
Member
|
We can't do this as easily as config server since. While config server jdbc needed to match git, this has always functioned this way and may break users. It needs to be behind a flag and users must opt in. The default can be changed in 4.0.x |
Author
|
I think it's a bug. the zookeeper config didn't use the same config order in |
ryanjbaxter
requested changes
Jan 12, 2023
Contributor
ryanjbaxter
left a comment
ryanjbaxter
left a comment
There was a problem hiding this comment.
We would need documentation for the property
woshikid
requested review from
ryanjbaxter
and removed request for
spencergibb
Author
|
Documentation added. |
ryanjbaxter
approved these changes
Jan 13, 2023
Author
|
@spencergibb a new flag is introduced as requested. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #302
config with profiles should have higher priority than others.