Open
Conversation
Move implementation to the SchemaBuilder API. This removes the cluncky JSON conversion type required for default values
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1003 +/- ##
==========================================
- Coverage 95.18% 94.91% -0.27%
==========================================
Files 51 51
Lines 1827 1811 -16
Branches 153 156 +3
==========================================
- Hits 1739 1719 -20
- Misses 88 92 +4 ☔ View full report in Codecov by Sentry. |
Contributor
Author
|
Avro 1.8 fails due to bug |
RustedBones
force-pushed
the
avro-schema-builder
branch
from
3e548d9 to
523cf2d
Compare
clairemcginty
approved these changes
Jul 22, 2024
Contributor
clairemcginty
left a comment
clairemcginty
left a comment
There was a problem hiding this comment.
much better, especially the JsonProperties defaults 🙏 since it does drop Avro 1.8 support, shall we make a branch/milestone to merge this into?
Contributor
|
If we adopt this into magnolify and subsequently into scio this means that we would force an upgrade past avro 1.8, correct? |
Contributor
Author
|
That's right. When mergeing this, avro 1.8 support will be dropped. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move implementation to the SchemaBuilder API.
This removes the cluncky JSON conversion type required for default values