Skip to content

BREAKING CHANGE: Remove shaded dependencies and use HttpClient interface #219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Abhi347 merged 11 commits into from
Mar 17, 2025

Merge branch 'master' into breaking-change/remove-shading-http

c64c195
Select commit
Loading
Failed to load commit list.
Merged

BREAKING CHANGE: Remove shaded dependencies and use HttpClient interface #219

Merge branch 'master' into breaking-change/remove-shading-http
c64c195
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch failed Mar 17, 2025 in 1s

74.54% of diff hit (target 76.89%)

View this Pull Request on Codecov

74.54% of diff hit (target 76.89%)

Annotations

Check warning on line 77 in src/main/java/com/spotify/github/http/okhttp/OkHttpHttpClient.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/com/spotify/github/http/okhttp/OkHttpHttpClient.java#L77 

Added line #L77 was not covered by tests

Check warning on line 98 in src/main/java/com/spotify/github/http/okhttp/OkHttpHttpClient.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/com/spotify/github/http/okhttp/OkHttpHttpClient.java#L97-L98 

Added lines #L97 - L98 were not covered by tests

Check warning on line 192 in src/main/java/com/spotify/github/http/okhttp/OkHttpHttpClient.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/com/spotify/github/http/okhttp/OkHttpHttpClient.java#L190-L192 

Added lines #L190 - L192 were not covered by tests

Check warning on line 231 in src/main/java/com/spotify/github/http/okhttp/OkHttpHttpClient.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/com/spotify/github/http/okhttp/OkHttpHttpClient.java#L222-L231 

Added lines #L222 - L231 were not covered by tests

Check warning on line 233 in src/main/java/com/spotify/github/http/okhttp/OkHttpHttpClient.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/com/spotify/github/http/okhttp/OkHttpHttpClient.java#L233 

Added line #L233 was not covered by tests

Check warning on line 71 in src/main/java/com/spotify/github/http/okhttp/OkHttpHttpResponse.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/com/spotify/github/http/okhttp/OkHttpHttpResponse.java#L71 

Added line #L71 was not covered by tests

Check warning on line 73 in src/main/java/com/spotify/github/http/okhttp/OkHttpHttpResponse.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/com/spotify/github/http/okhttp/OkHttpHttpResponse.java#L73 

Added line #L73 was not covered by tests

Check warning on line 77 in src/main/java/com/spotify/github/http/okhttp/OkHttpHttpResponse.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/com/spotify/github/http/okhttp/OkHttpHttpResponse.java#L77 

Added line #L77 was not covered by tests

Check warning on line 93 in src/main/java/com/spotify/github/http/okhttp/OkHttpHttpResponse.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/com/spotify/github/http/okhttp/OkHttpHttpResponse.java#L92-L93 

Added lines #L92 - L93 were not covered by tests

Check warning on line 36 in src/main/java/com/spotify/github/tracing/BaseTracer.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/com/spotify/github/tracing/BaseTracer.java#L36 

Added line #L36 was not covered by tests

Check warning on line 47 in src/main/java/com/spotify/github/tracing/BaseTracer.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/com/spotify/github/tracing/BaseTracer.java#L47 

Added line #L47 was not covered by tests

Check warning on line 39 in src/main/java/com/spotify/github/tracing/NoopTracer.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/com/spotify/github/tracing/NoopTracer.java#L39 

Added line #L39 was not covered by tests

Check warning on line 47 in src/main/java/com/spotify/github/tracing/NoopTracer.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/com/spotify/github/tracing/NoopTracer.java#L47 

Added line #L47 was not covered by tests

Check warning on line 52 in src/main/java/com/spotify/github/tracing/NoopTracer.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/com/spotify/github/tracing/NoopTracer.java#L52 

Added line #L52 was not covered by tests

Check warning on line 57 in src/main/java/com/spotify/github/tracing/NoopTracer.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/com/spotify/github/tracing/NoopTracer.java#L57 

Added line #L57 was not covered by tests

Check warning on line 62 in src/main/java/com/spotify/github/tracing/NoopTracer.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/com/spotify/github/tracing/NoopTracer.java#L62 

Added line #L62 was not covered by tests

Check warning on line 67 in src/main/java/com/spotify/github/tracing/NoopTracer.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/com/spotify/github/tracing/NoopTracer.java#L67 

Added line #L67 was not covered by tests

Check warning on line 75 in src/main/java/com/spotify/github/tracing/NoopTracer.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/com/spotify/github/tracing/NoopTracer.java#L75 

Added line #L75 was not covered by tests

Check warning on line 53 in src/main/java/com/spotify/github/tracing/opentelemetry/OpenTelemetryTracer.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/com/spotify/github/tracing/opentelemetry/OpenTelemetryTracer.java#L53 

Added line #L53 was not covered by tests

Check warning on line 111 in src/main/java/com/spotify/github/tracing/opentelemetry/OpenTelemetryTracer.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/com/spotify/github/tracing/opentelemetry/OpenTelemetryTracer.java#L111 

Added line #L111 was not covered by tests

Check warning on line 180 in src/main/java/com/spotify/github/v3/clients/GitHubClient.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/com/spotify/github/v3/clients/GitHubClient.java#L180 

Added line #L180 was not covered by tests

Check warning on line 205 in src/main/java/com/spotify/github/v3/clients/GitHubClient.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/com/spotify/github/v3/clients/GitHubClient.java#L205 

Added line #L205 was not covered by tests

Check warning on line 219 in src/main/java/com/spotify/github/v3/clients/GitHubClient.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/com/spotify/github/v3/clients/GitHubClient.java#L219 

Added line #L219 was not covered by tests

Check warning on line 272 in src/main/java/com/spotify/github/v3/clients/GitHubClient.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/com/spotify/github/v3/clients/GitHubClient.java#L272 

Added line #L272 was not covered by tests

Check warning on line 325 in src/main/java/com/spotify/github/v3/clients/GitHubClient.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/com/spotify/github/v3/clients/GitHubClient.java#L325 

Added line #L325 was not covered by tests
View more details on Codecov