This repository was archived by the owner on Oct 1, 2020. It is now read-only.
Add default advertised host and topic creation#71
Open
cyx wants to merge 1 commit intospotify:masterfrom
Open
Conversation
|
Thanks for this patch, @cyx - I was looking for exactly this. I've forked this Dockerfile and pulled your patch and published to the Docker Hub All commits still in-tact, and hopefully @mbruggmann notices that a lot of people use this library and picks up the maintenance |
Member
|
Maybe @dflemstr knows more about the newer kafka versions? I haven't had time to keep up with recent developments unfortunately... |
|
@mbruggmann there are 23 pull requests, most without dialog. May I suggest that you add something to the README that says pull requests won't be accepted and that this image is unlikely to change? (If that is the case, of course) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reasons for change
docker-compose.ymlenviromentsection seems a tad better.TODO