This repository was archived by the owner on Oct 1, 2020. It is now read-only.
Configure list of topics to be created#29
Open
bcwalrus wants to merge 2 commits intospotify:masterfrom
Open
Conversation
bcwalrus
force-pushed
the
upstream
branch
2 times, most recently
from
e837807 to
f04cf1c
Compare
Support KAFKA_CREATE_TOPICS, which is a comma separated list of:
<name>:<n_partitions>:<repl_factor>
Code copied from https://github.com/wurstmeister/kafka-docker under
the ASL v2 license.
|
Thanks @bcwalrus, great addition. I was about to start working on it. Hopefully this will get merged soon. |
zoidyzoidzoid
added a commit
to Superbalist/docker-kafka
that referenced
this pull request
Feb 17, 2016
which comes from spotify/pull/29
zoidyzoidzoid
added a commit
to Superbalist/docker-kafka
that referenced
this pull request
Feb 17, 2016
which comes from spotify/pull/29
We were running Kafka in the background, and use the startup script to create topics after Kafka has started. Instead, create the Kafka topics in a subprocess (especially since it'll wait for Kafka to start), and exec Kafka to keep the supervisor chain of control.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support KAFKA_CREATE_TOPICS, which is a comma separated list of:
Code copied from https://github.com/wurstmeister/kafka-docker under
the ASL v2 license.