Switch to ruff for linting/formatting#113
Merged
elbersb merged 2 commits intospotify:masterfrom Jan 13, 2026
Merged
Conversation
iampelle
approved these changes
Jan 13, 2026
Collaborator
iampelle
left a comment
iampelle
left a comment
There was a problem hiding this comment.
I had a quick look, and it just reformatting and re-ordering imports, right? If so feel free to merge. We can change import style to import modules rather than constants/functions/classes and remove ./.. from imports in a separate PR.
|
|
||
| from spotify_confidence.chartgrid import ChartGrid | ||
|
|
||
| from ..constants import NIM_TYPE |
Collaborator
There was a problem hiding this comment.
Hmm, we probably shouldn't use . and .. in imports. As long as we have the right init files it should be possible to from spotify_confidence.analysis import constants.
Collaborator
Author
There was a problem hiding this comment.
yeah this one was also only reordered, we can change that in a follow-up PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Might be worth extending the rules, but then more needs to be fixed. e.g.
uv run ruff check --select B(common bugs) shows 16 errors.