fix: close OkHttp response bodies to prevent connection leaks#237
Merged
fix: close OkHttp response bodies to prevent connection leaks#237
Conversation
Use Response.use {} to ensure OkHttp response bodies are always closed,
preventing "connection was leaked" warnings. Affected call sites:
- FlagApplierClientImpl (flags:apply)
- EventSenderUploaderImpl (events:publish)
- RemoteFlagResolver (flags:resolve)
Made-with: Cursor
fabriziodemaria
requested review from
nicklasl,
nickybondarenko and
vahidlazio
as code owners
Previously, toResolveFlags() would log the error but still attempt to deserialize the response body on HTTP errors, leading to confusing parse exceptions. Now it throws immediately with the HTTP status code. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…onses Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
nicklasl
approved these changes
Mar 26, 2026
Member
nicklasl
left a comment
nicklasl
left a comment
There was a problem hiding this comment.
Added a small adjustment (introduced a http error exception)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Responseobjects in.use {}blocks across all HTTP call sites to ensure response bodies are always closed, fixing the"A connection to https://resolver.eu.confidence.dev/ was leaked"warning.applyInteractor.invoke()was never closed.body.close()in afinallyblock withResponse.use {}for safer, simpler cleanup.Test plan
Made with Cursor