Skip to content

Comment out dead layer code in models.py #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hyperc54 merged 1 commit into from
Nov 11, 2025
Merged

Comment out dead layer code in models.py #180

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 14 additions & 11 deletions basic_pitch/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,17 +223,20 @@ def model(
N_FREQ_BINS_CONTOURS,
)(x)

# contour layers - fully convolutional
x_contours = tfkl.Conv2D(
n_filters_contour,
CONTOUR_KERNEL_SIZE_1,
padding="same",
kernel_initializer=_initializer(),
kernel_constraint=_kernel_constraint(),
)(x)

x_contours = tfkl.BatchNormalization()(x_contours)
x_contours = tfkl.ReLU()(x_contours)
# contour layers - fully convolutional - /!\ commented out as it was unintentionally skipped
# when training the model presented in the paper.
# TODO: retrain with layer included and replace checkpoints if it yields benefits
#
# x_contours = tfkl.Conv2D(
# n_filters_contour,
# CONTOUR_KERNEL_SIZE_1,
# padding="same",
# kernel_initializer=_initializer(),
# kernel_constraint=_kernel_constraint(),
# )(x)

# x_contours = tfkl.BatchNormalization()(x_contours)
# x_contours = tfkl.ReLU()(x_contours)

x_contours = tfkl.Conv2D(
CONTOUR_FILTERS_2,
Expand Down