Skip to content

perf(map): reduce mobile overlay animation work#15

Merged
seoJing merged 1 commit into
mainfrom
perf/map-mobile-overlay-redraw
Jun 1, 2026
Merged

perf(map): reduce mobile overlay animation work#15
seoJing merged 1 commit into
mainfrom
perf/map-mobile-overlay-redraw

Conversation

@seoJing
Copy link
Copy Markdown
Member

@seoJing seoJing commented Jun 1, 2026

Summary

  • Batch static Naver overlay redraws through a map-level registry instead of installing idle/zoom/bounds listeners per overlay
  • Add persona-dot pulse budgeting for dense, low-zoom, and coarse-pointer map states while keeping persona dots visible
  • Add marker visual-mode unit coverage for the new pulse budget

Test Plan

  • pnpm test src/features/map/model/marker-visual-mode.test.ts
  • pnpm test
  • pnpm lint
  • pnpm build
  • Browser smoke: /map renders with no console JS errors and dense viewport disables persona pulse nodes

Notjing

  • notjing gate: pass

@vercel
Copy link
Copy Markdown

vercel Bot commented Jun 1, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
frontend Ready Ready Preview, Comment Jun 1, 2026 4:02pm

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jun 1, 2026

Warning

Review limit reached

@seoJing, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 42 minutes and 22 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: e533b941-33c8-481d-81f6-afa25cac454f

📥 Commits

Reviewing files that changed from the base of the PR and between 493a5bd and b366f38.

📒 Files selected for processing (4)
  • src/features/map/client/MapClient.tsx
  • src/features/map/model/marker-visual-mode.test.ts
  • src/features/map/model/marker-visual-mode.ts
  • src/features/map/ui/MapCanvas.tsx
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch perf/map-mobile-overlay-redraw

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@seoJing seoJing merged commit f31bfa1 into main Jun 1, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant