use separte set_fact for bearer token or basic auth download#844
Open
tod-uma wants to merge 1 commit intosplunk:developfrom
Open
use separte set_fact for bearer token or basic auth download#844tod-uma wants to merge 1 commit intosplunk:developfrom
tod-uma wants to merge 1 commit intosplunk:developfrom
Conversation
Contributor
Author
|
fixes #845 |
jmeixensperger
approved these changes
Sep 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when trying to install a tgz from a no auth url, I ran into a bug where the task "Define a path for the downloaded package" would fail because
download_resultdid not contain a keydest. This is because thedownload_resultvariable gets overwritten by the basic_auth task even though it gets skipped. This patch simply provides a separate "Define a path for the downloaded package" task for each download task.