fix(generator): inspect installed distribution metadata#2033
Open
artemrys wants to merge 2 commits into
Open
Conversation
Replace pip-show based dependency verification with target metadata lookups. Rename the helper to match the new behavior and add unit coverage. Mostly created by Codex.
Code Coverage 🎉
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number:
#1642
PR Type
What kind of change does this PR introduce?
Summary
Changes
pip showbased library verification with installed distribution metadata lookups under the build target directorysplunktaucclibfrom target metadata and update related tests to reflect the new verification flowUser experience
Before this change,
ucc-gen buildcould report thatsplunktaucclibwas missing even when it had been installed into the add-onlibdirectory, because the verification step inspected the active Python environment instead of the built add-on contents.After this change, the verification step checks the installed package metadata in the target add-on directory, so builds correctly recognize bundled
splunktauccliband other required libraries.Checklist
If an item doesn't apply to your changes, leave it unchecked.
Review
Tests
See the testing doc.
Demo/meeting:
None.
Reviewers are encouraged to request meetings or demos if any part of the change is unclear