Skip to content

fix(generator): inspect installed distribution metadata#2033

Open
artemrys wants to merge 2 commits into
developfrom
codex/fix-installed-distribution-detection
Open

fix(generator): inspect installed distribution metadata#2033
artemrys wants to merge 2 commits into
developfrom
codex/fix-installed-distribution-detection

Conversation

@artemrys

Copy link
Copy Markdown
Member

Issue number:
#1642

PR Type

What kind of change does this PR introduce?

  • Feature
  • Bug Fix
  • Refactoring (no functional or API changes)
  • Documentation Update
  • Maintenance (dependency updates, CI, etc.)

Summary

Changes

  • replace pip show based library verification with installed distribution metadata lookups under the build target directory
  • rename the helper to match its new behavior and remove the unused installer argument from that path
  • add focused unit coverage for detecting splunktaucclib from target metadata and update related tests to reflect the new verification flow

User experience

Before this change, ucc-gen build could report that splunktaucclib was missing even when it had been installed into the add-on lib directory, because the verification step inspected the active Python environment instead of the built add-on contents.

After this change, the verification step checks the installed package metadata in the target add-on directory, so builds correctly recognize bundled splunktaucclib and other required libraries.

Checklist

If an item doesn't apply to your changes, leave it unchecked.

Review

  • self-review - I have performed a self-review of this change according to the development guidelines
  • Changes are documented. The documentation is understandable, examples work (more info)
  • PR title and description follows the contributing principles
  • meeting - I have scheduled a meeting or recorded a demo to explain these changes (if there is a video, put a link below and in the ticket)

Tests

See the testing doc.

  • Unit - tests have been added/modified to cover the changes
  • Smoke - tests have been added/modified to cover the changes
  • UI - tests have been added/modified to cover the changes
  • coverage - I have checked the code coverage of my changes (see more)

Demo/meeting:

None.

Reviewers are encouraged to request meetings or demos if any part of the change is unclear

Replace pip-show based dependency verification with target metadata lookups.
Rename the helper to match the new behavior and add unit coverage.

Mostly created by Codex.
@artemrys artemrys requested a review from a team as a code owner April 24, 2026 14:31
@github-actions github-actions Bot requested a review from a team as a code owner April 24, 2026 14:34
@github-actions github-actions Bot requested a review from soleksy-splunk April 24, 2026 14:34
@github-actions

Copy link
Copy Markdown

Code Coverage 🎉

Type PR Develop Change Status
Line Coverage 94.38% 94.38% 0.00% 🔴 Decreased
Branch Coverage 90.68% 90.66% 0.03% 🟢 Increased

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants