Conversation
marctrem
force-pushed
the
marctrem/chain-validation
branch
from
0208d1c to
6796a2f
Compare
laura-splits
approved these changes
Aug 18, 2025
marctrem
force-pushed
the
marctrem/chain-validation
branch
2 times, most recently
from
5837736 to
ef8f293
Compare
marctrem
force-pushed
the
marctrem/chain-validation
branch
from
ef8f293 to
41ef4d1
Compare
laura-splits
approved these changes
Aug 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Built-in cert validation requires the caller to provide a point in time in which the chain should be valid.
This change puts the responsibility of verifying the time-validity of the chain on the caller.
This allows the caller to ensure that the attestation was valid in the context of the use case it was created for.