Revert "Gnome 49 adaptation"#2
Closed
spitzerl wants to merge 1 commit into
Closed
Conversation
There was a problem hiding this comment.
Pull request overview
This PR reverts the prior “GNOME 49 adaptation” changes, restoring the extension’s earlier GNOME Shell window-management API usage and updating documentation to reflect a narrower support target.
Changes:
- Replace GNOME 49-specific window APIs/types (e.g.,
Mtk.Rectangle, maximize flag setters) with older equivalents (Meta.Rectangle,maximize()/unmaximize(),get_maximized()checks). - Update README to state support is only for GNOME 45 and simplify installation instructions to the extensions.gnome.org link.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
src/extension.js |
Reverts GNOME 49 adaptation API changes (rectangle type + maximize/restore + maximized state checks). |
README.md |
Narrows documented support to GNOME 45 and removes manual install steps in favor of the GNOME Extensions listing. |
Comments suppressed due to low confidence (1)
src/extension.js:564
- The tile-preview rectangle type was switched back to Meta.Rectangle, but the extension metadata still declares support up to GNOME Shell 49. If GNOME 49 expects Mtk.Rectangle (as implied by the reverted adaptation), this will break the preview on 49. Either reintroduce a version/feature-detection shim for the rectangle type (supporting both Meta.Rectangle and Mtk.Rectangle) or update the advertised supported shell versions to match the APIs used.
global.window_manager.emit("show-tile-preview",
global.display.get_focus_window(), new Meta.Rectangle(
{ x: rx, y: ry, width: rw, height: rh }
)
, this._monitorId
);
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
| if (this._targetWindow.can_maximize()) { | ||
| this._resetWinPos(); | ||
| this._targetWindow.set_maximize_flags(Meta.MaximizeFlags.BOTH); | ||
| this._targetWindow.maximize(Meta.MaximizeFlags.BOTH); |
| if (setmove) { | ||
| if (this._targetWindow.allows_move() && | ||
| !this._targetWindow.is_maximized()) { | ||
| !this._targetWindow.get_maximized()) { |
| if (this._actionWidgets[wid] && (progress > 0)) { | ||
| if (ui == 1) { | ||
| activeWin.set_maximize_flags(Meta.MaximizeFlags.BOTH); | ||
| activeWin.maximize(Meta.MaximizeFlags.BOTH); |
Comment on lines
+2650
to
2653
| activeWin.unmaximize( | ||
| Meta.MaximizeFlags.BOTH | ||
| ); | ||
| if (activeWin.isTiled) { |
|
|
||
| Window Gestures is GNOME Shell extension for managing window with touchpad gestures. | ||
| Support up to gnome 49. | ||
| Support only for GNOME 45. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #1