Skip to content

Revert "Gnome 49 adaptation"#2

Closed
spitzerl wants to merge 1 commit into
mainfrom
revert-1-gnome-49-adaptation
Closed

Revert "Gnome 49 adaptation"#2
spitzerl wants to merge 1 commit into
mainfrom
revert-1-gnome-49-adaptation

Conversation

@spitzerl
Copy link
Copy Markdown
Owner

Reverts #1

Copilot AI review requested due to automatic review settings March 18, 2026 01:33
@spitzerl spitzerl closed this Mar 18, 2026
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR reverts the prior “GNOME 49 adaptation” changes, restoring the extension’s earlier GNOME Shell window-management API usage and updating documentation to reflect a narrower support target.

Changes:

  • Replace GNOME 49-specific window APIs/types (e.g., Mtk.Rectangle, maximize flag setters) with older equivalents (Meta.Rectangle, maximize()/unmaximize(), get_maximized() checks).
  • Update README to state support is only for GNOME 45 and simplify installation instructions to the extensions.gnome.org link.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.

File Description
src/extension.js Reverts GNOME 49 adaptation API changes (rectangle type + maximize/restore + maximized state checks).
README.md Narrows documented support to GNOME 45 and removes manual install steps in favor of the GNOME Extensions listing.
Comments suppressed due to low confidence (1)

src/extension.js:564

  • The tile-preview rectangle type was switched back to Meta.Rectangle, but the extension metadata still declares support up to GNOME Shell 49. If GNOME 49 expects Mtk.Rectangle (as implied by the reverted adaptation), this will break the preview on 49. Either reintroduce a version/feature-detection shim for the rectangle type (supporting both Meta.Rectangle and Mtk.Rectangle) or update the advertised supported shell versions to match the APIs used.
        global.window_manager.emit("show-tile-preview",
            global.display.get_focus_window(), new Meta.Rectangle(
                { x: rx, y: ry, width: rw, height: rh }
            )
            , this._monitorId
        );

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Comment thread src/extension.js
if (this._targetWindow.can_maximize()) {
this._resetWinPos();
this._targetWindow.set_maximize_flags(Meta.MaximizeFlags.BOTH);
this._targetWindow.maximize(Meta.MaximizeFlags.BOTH);
Comment thread src/extension.js
if (setmove) {
if (this._targetWindow.allows_move() &&
!this._targetWindow.is_maximized()) {
!this._targetWindow.get_maximized()) {
Comment thread src/extension.js
if (this._actionWidgets[wid] && (progress > 0)) {
if (ui == 1) {
activeWin.set_maximize_flags(Meta.MaximizeFlags.BOTH);
activeWin.maximize(Meta.MaximizeFlags.BOTH);
Comment thread src/extension.js
Comment on lines +2650 to 2653
activeWin.unmaximize(
Meta.MaximizeFlags.BOTH
);
if (activeWin.isTiled) {
Comment thread README.md

Window Gestures is GNOME Shell extension for managing window with touchpad gestures.
Support up to gnome 49.
Support only for GNOME 45.
@spitzerl spitzerl deleted the revert-1-gnome-49-adaptation branch March 18, 2026 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants