This repository was archived by the owner on Jul 10, 2021. It is now read-only.
docs(aws): AWS Launch Template only applicable for 1.23 and above#2098
Merged
kevinawoo merged 5 commits intospinnaker:masterfrom Dec 3, 2020
Merged
docs(aws): AWS Launch Template only applicable for 1.23 and above#2098kevinawoo merged 5 commits intospinnaker:masterfrom
kevinawoo merged 5 commits intospinnaker:masterfrom
Conversation
…ated instructions.
Contributor
|
Can you PTAL for the technical side @kevinawoo |
Contributor
Author
|
Forgot to note that this resolves Issue: #2091 |
kevinawoo
changed the title
kevinawoo
suggested changes
Dec 2, 2020
Member
kevinawoo
left a comment
kevinawoo
left a comment
There was a problem hiding this comment.
Added some comments for the review.
@brian-armory do we have a process for 1.24 to remember to uncomment out these sections?
Co-authored-by: Kevin Woo <kevinawoo@gmail.com>
kevinawoo
approved these changes
Dec 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
updated the instructions.