Skip to content

Conversation

@karthik2804
Copy link
Collaborator

I need to verify that the debugger works.

Copy link
Member

@radu-matei radu-matei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This requires a rebase now to resolve conflicts.

Thanks!

Signed-off-by: Karthik Ganeshram <karthik.ganeshram@fermyon.com>
Signed-off-by: Karthik Ganeshram <karthik.ganeshram@fermyon.com>
Add a readme note on how to use the debugger. Also adds a commented out
outbound host for debugger connection and a npm script to build debug.

Signed-off-by: Karthik Ganeshram <karthik.ganeshram@fermyon.com>
Copy link
Collaborator

@tschneidereit tschneidereit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you!

The only comments I left inline are about whether to switch from spin up to spin watch, which might resolve some issues with the debugger, but for all I know might also introduce others. If you haven't already, I think testing that would be good.

"componentRuntime": {
"executable": "spin",
"options": [
"up",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one thing to consider here is to change this to watch. That'd probably require/enable other changes to the lifecycle, as the process wouldn't need to be restarted when content changes.

"componentRuntime": {
"executable": "spin",
"options": [
"up",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment as for the http-js template

"componentRuntime": {
"executable": "spin",
"options": [
"up",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... and same here

@karthik2804
Copy link
Collaborator Author

@tschneidereit Thoughts on landing this as is and I can test the spin watch change and open a future PR?

@karthik2804
Copy link
Collaborator Author

I also think we would need build profiles to tightly integrate with the spin build command.

@tschneidereit
Copy link
Collaborator

I also think we would need build profiles to tightly integrate with the spin build command.

Oh, that's a good point! Yeah, with that in mind I agree that landing this as-is makes sense.

@karthik2804 karthik2804 merged commit d11f4ab into spinframework:main Dec 11, 2025
11 checks passed
@karthik2804 karthik2804 deleted the update_templates branch December 11, 2025 14:39
@tschneidereit
Copy link
Collaborator

This makes me realize that it'd be valuable to have a watch mode that doesn't trigger a rebuild, but just a reload of the wasm file if that changes

@itowlson
Copy link
Contributor

This makes me realize that it'd be valuable to have a watch mode that doesn't trigger a rebuild, but just a reload of the wasm file if that changes

spin watch --skip-build unless I'm misunderstanding you

@tschneidereit
Copy link
Collaborator

You're not: I had forgotten that exists! @karthik2804 might be useful to update the templates to use that, since it'd allow us to avoid having to restart spin between debugging sessions

@itowlson
Copy link
Contributor

I have a feeling that spin watch starts new spin up/spin trigger http processes so I am not sure that any debugger attachment will remain, but I'm not sufficiently confident with either spin watch or the debugger to say for sure...!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants