docs(v4): postgres and sqlite python updates#190
Conversation
|
🚀 preview deployed successfully to Fermyon Cloud and available at https://spin-docs-pr-190-rt3oaa1u.fermyon.app |
itowlson
left a comment
itowlson
left a comment
There was a problem hiding this comment.
LGTM (once, as you say, the TBA URLs go in) - thanks!
|
|
||
| > As seen in the example above, you can utilize the [collect](https://spinframework.github.io/spin-python-sdk/v4/util.html#spin_sdk.util.collect) method from the `util` package to handle the `StreamReader` and `FutureReader` pair, aggregating the resulting rows into memory. | ||
|
|
||
| * The `Connection` object doesn't surface the `close` function. |
There was a problem hiding this comment.
Components can't deterministically close a connection? (Oh is this to get around "what if they close it while the row stream is still being traversed" kind of thing?)
There was a problem hiding this comment.
Yea, not quite sure of the genesis of this entry (predates the updated v4 docs) Ah, I see I swiped this from the pre-existing note in the sqlite guide. Remove/update both?
There was a problem hiding this comment.
If it's true, then keep. If it's untrue, then remove. (My guess is copypasta from the Rust Connection object around the time we switched from "pass the address" to "methods on a resource".)
There was a problem hiding this comment.
I'm going to say it is true insofar as neither the SDK nor the underlying WITs surface a close function. As to why they don't, I'm not sure on the details.
There was a problem hiding this comment.
Oh, perhaps because the connection resource doesn't, and you instead use resource drop functionality? Not a worry for now, let's review after 4.0 and figure out 1. if Spin is doing this correctly and 2. how to surface it in SDKs. Sorry for the noise.
Signed-off-by: Vaughn Dice <vdice@akamai.com>
vdice
force-pushed
the
docs/v4/py-postgres-sqlite-updates
branch
from
5ec33ce to
ef3a703
Compare
2 participants
Ref spinframework/spin-python-sdk#148
TODO: