Skip to content

Update scripts#24

Merged
fondation451 merged 1 commit intomainfrom
update-script
Sep 23, 2025
Merged

Update scripts#24
fondation451 merged 1 commit intomainfrom
update-script

Conversation

@fondation451
Copy link
Copy Markdown
Collaborator

No description provided.

@fondation451 fondation451 self-assigned this Sep 23, 2025
Copilot AI review requested due to automatic review settings September 23, 2025 17:03
@fondation451 fondation451 merged commit 4e61dcb into main Sep 23, 2025
5 checks passed
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Updates deployment scripts to make parameters required and improves configuration handling by removing hardcoded values and adding proper parameter validation.

  • Made script parameters required instead of using default values
  • Added relayer address as a required parameter to relevant scripts
  • Replaced hardcoded admin address with dynamic retrieval from stellar profile

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
scripts/setup_contracts.sh Added relayer address parameter requirement and validation
scripts/generate_contract_libraries.sh Removed default values for environment and network parameters
scripts/deploy_contracts.sh Replaced hardcoded admin address with dynamic retrieval from stellar profile
scripts/bootstrap.sh Added relayer address parameter and updated script calls accordingly

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

#!/bin/bash

#### Usage: ./scripts/generate_contract_libraries.sh dev testnet

Copy link

Copilot AI Sep 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Parameters are now required but there's no validation to check if they are provided. This could lead to scripts running with empty values, causing unexpected behavior. Consider adding validation checks similar to the other scripts.

Suggested change
# Check for required parameters
if [ -z "$1" ] || [ -z "$2" ]; then
echo "Usage: $0 <environment> <network>"
echo "Example: $0 dev testnet"
exit 1
fi

Copilot uses AI. Check for mistakes.
Comment thread scripts/bootstrap.sh
./scripts/deploy_contracts.sh $ENVIRONMENT $STELLAR_PROFILE $NETWORK
./scripts/setup_contracts.sh $ENVIRONMENT $STELLAR_PROFILE $NETWORK
./scripts/setup_contracts.sh $ENVIRONMENT $STELLAR_PROFILE $NETWORK $RELAYER_ADDRESS
./scripts/generate_contract_libraries.sh
Copy link

Copilot AI Sep 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The generate_contract_libraries.sh script call is missing the required ENVIRONMENT and NETWORK parameters that were made mandatory in the script changes.

Suggested change
./scripts/generate_contract_libraries.sh
./scripts/generate_contract_libraries.sh $ENVIRONMENT $NETWORK

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants