Closed
Conversation
… to v2.47.22 Replace tokio-uring (pre-1.0, forces separate runtime) with the raw io-uring 0.7 crate. Adds kernel probe at init — fails gracefully on AWS Amazon Linux, ECS, Lambda, seccomp-filtered containers, and kernels < 5.1. Worker thread runs a synchronous io_uring submit/reap loop with no async runtime, no mutexes, and no deadlock paths. - Swap dep: tokio-uring 0.5 → io-uring 0.7 - Rewrite uring_fs.rs io_uring inner: raw SQE/CQE ops (OpenAt, Write, Read, Close) with short-write/short-read loops and guaranteed fd cleanup - Unify connect.rs init_background_runtime into single impl (both paths use standard tokio runtime; io_uring only for file I/O) - Remove .expect() panic site in send_to_background_runtime - StreamingWriter always uses tokio::fs fallback (io_uring adds no value for sequential streaming) - 18 tests: 13 cross-platform fallback + 5 Linux-only io_uring path Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Member
|
Hi the PR has some conflicts and it looks like it has domain specific logic instead of being generic. |
Member
|
Closing this PR — we cherry-picked the generic CLI improvements into main (v2.47.47): Pulled in:
Not pulled in:
Thank you for the contribution! The core idea of exposing spider's chrome connection and cookie configs to the CLI was the right call. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.