Fix incorrect assertion in test_extract_messages_without_rawsource#14268
Open
bodhisilberling wants to merge 1 commit intosphinx-doc:masterfrom
Open
Fix incorrect assertion in test_extract_messages_without_rawsource#14268bodhisilberling wants to merge 1 commit intosphinx-doc:masterfrom
bodhisilberling wants to merge 1 commit intosphinx-doc:masterfrom
Conversation
The assertion was checking truthiness instead of comparing the extracted message to the expected value 'text sentence'. Changed to properly compare using == operator.
jayaddison
reviewed
Jan 19, 2026
| _transform(document) | ||
| assert_node_count(extract_messages(document), nodes.TextElement, 1) | ||
| assert next(m for n, m in extract_messages(document)), 'text sentence' | ||
| assert next(m for n, m in extract_messages(document)) == 'text sentence' |
Contributor
There was a problem hiding this comment.
Suggested change
| assert next(m for n, m in extract_messages(document)) == 'text sentence' | |
| assert next(m for n, m in extract_messages(document)) == 'testsentence' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The assertion was checking truthiness instead of comparing the extracted message to the expected value 'text sentence'. Changed to properly compare using == operator.
Purpose
References