Revert "singlehtml: deprecate the 'fix_refuris' helper function (#13037)"#14241
Open
jayaddison wants to merge 4 commits intosphinx-doc:masterfrom
Open
Revert "singlehtml: deprecate the 'fix_refuris' helper function (#13037)"#14241jayaddison wants to merge 4 commits intosphinx-doc:masterfrom
jayaddison wants to merge 4 commits intosphinx-doc:masterfrom
Conversation
Specifically, check for duplication of the HTML anchor fragment delimiter character (`#`). Co-authored-by: @etrian-dev
…nx-doc#13037)" This reverts commit c93723b. Conflicts: CHANGES.rst doc/extdev/deprecated.rst sphinx/builders/singlehtml.py
Contributor
Author
|
Self-quoting:
Please refer to this comment for the results of this investigation: #14221 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
As reported in #14221, the
fix_refurismethod does appear to prevent duplicate fragment delimiters (the#character) from appearing in the hyperlinks output by thesinglehtmlbuilder.In my opinion we should still consider
fix_refurisdeprecated -- I'd still like to remove it, since it seems like an unnecessary post-processing of the documents; but additional investigation is required to confirm what it does and whether a better alternative mechanism can be found.References