Skip to content

update Go version to 1.17 #2366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alexandear wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −8
Open

update Go version to 1.17 #2366

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions .golangci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,10 +57,3 @@ linters:
- common-false-positives
- legacy
- std-error-handling
settings:
govet:
# Disable buildtag check to allow dual build tag syntax (both //go:build and // +build).
# This is necessary for Go 1.15 compatibility since //go:build was introduced in Go 1.17.
# This can be removed once Cobra requires Go 1.17 or higher.
disable:
- buildtag
4 changes: 3 additions & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,12 @@
module github.com/spf13/cobra

go 1.15
go 1.17

require (
github.com/cpuguy83/go-md2man/v2 v2.0.6
github.com/inconshreveable/mousetrap v1.1.0
github.com/spf13/pflag v1.0.9
go.yaml.in/yaml/v3 v3.0.4
)

require github.com/russross/blackfriday/v2 v2.1.0 // indirect
Copy link
Copy Markdown
Contributor

@ccoVeille ccoVeille Mar 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm surprised to see thus one popping here

Copy link
Copy Markdown
Author

@alexandear alexandear Mar 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's an indirect dependency of github.com/cpuguy83/go-md2man/v2/md2man:

❯ go1.17 mod why -m github.com/russross/blackfriday/v2
# github.com/russross/blackfriday/v2
github.com/spf13/cobra/doc
github.com/cpuguy83/go-md2man/v2/md2man
github.com/russross/blackfriday/v2