tests: add test_lnwallet to test lnwallet utils#10363
Merged
SomberNight merged 1 commit intospesmilo:masterfrom Jan 12, 2026
Merged
tests: add test_lnwallet to test lnwallet utils#10363SomberNight merged 1 commit intospesmilo:masterfrom
SomberNight merged 1 commit intospesmilo:masterfrom
Conversation
Member
|
I would very much prefer if we stopped mocking up LNWallet. Of course what I am saying is not conflicting with this pull request. |
Member
Author
Ok, then lets do this instead of extending dependency on the mock. |
Adds new unittest file test_lnwallet.py to allow unittesting utility functions of LNWallet.
f321x
force-pushed
the
unittest_lnwallet
branch
from
a6cdd93 to
562839c
Compare
Member
Author
|
This now uses the new |
SomberNight
approved these changes
Jan 12, 2026
Member
SomberNight
left a comment
SomberNight
left a comment
There was a problem hiding this comment.
Looks good to me. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It would be nice to have some way to test the (utility) methods of
LNWalletto allow for more coverage and detect regressions like #10350 before they reach the GUI etc.So i added test_lnwallet.py as a place to test
LNWalletthings like the creation ofPaymentInfo.