Conversation
…rge-check-agentic-workspace-phase-1-positioning # Conflicts: # packages/server/src/__tests__/session-commands.test.ts # packages/server/src/server.ts # packages/server/src/storage/db.ts # packages/server/src/storage/migrations/001_init.sql # packages/server/src/storage/schema-version.ts # packages/server/src/supervisor/manager.ts # packages/server/src/ws/dispatch.ts
…elcome-first-session-activation
When the websocket drops out, the global connection banner already explains the situation. Surfacing additional recovery overlays/notices on top of that produced a 'failure' UX even though the coordinator's pendingSocketReconcile would transparently recover once the socket reconnects. Two complementary guards: 1. failHistoricalRecovery now short-circuits to a quiet loading state when wsClient.getStatus() != 'connected', deferring to deferRecoveryUntilReconnect for resume. 2. showInlineRecoveryNotice and showReplayOverlay only render when wsHealthy is true, so even a stale failure state never stacks with the connection banner. Adds a regression test that mocks getStatus() = 'disconnected' alongside replay/snapshot failures and asserts no recovery notice or blocking overlay appears.
The 'truncated' kind in TerminalReplayUiState was declared in the union but never produced by any setReplayUiState call site, and the matching zh/en locale strings were dead. Now that 'snapshot success counts as success' is the intended semantic (no partial-history notice needed), drop the unreachable branch, type member, and locale entries to shrink the state space.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
developbranch intomain@spencer-kit/coder-studioVerification
fnm exec --using 24.16.0 pnpm ci:verify