Refactor CreatorFilter to Generic UserFilter#1769
Refactor CreatorFilter to Generic UserFilter#1769KCarretto wants to merge 1 commit intofeat/assets-pagefrom
Conversation
- Renamed `UserFilterBar` to `UserFilter` and made it a generic, controlled component. - Updated `FilterControls` to use the new `UserFilter`. - Renamed `creatorId` to `userId` in `FilterContext` and `Assets` page. - Updated all relevant tests in `FilterContext.test.tsx` and added coverage for `CREATOR` and `ASSET_NAME` filter counts. Co-authored-by: KCarretto <16250309+KCarretto@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
This change refactors the
UserFilterBarcomponent into a more genericUserFiltercomponent that can be reused for other user filtering needs. It also renames thecreatorIdstate variable in theFilterContexttouserIdto reflect its more general purpose. All associated tests have been updated, and new test cases for filter counting have been added.PR created automatically by Jules for task 9715909268083601840 started by @KCarretto