Skip to content

fix(ui-bug): Moves isLocked to not trigger filter state changes#1764

Merged
hulto merged 3 commits intomainfrom
ui-virtualized-table-lock-fix
Feb 14, 2026
Merged

fix(ui-bug): Moves isLocked to not trigger filter state changes#1764
hulto merged 3 commits intomainfrom
ui-virtualized-table-lock-fix

Conversation

@cmp5987
Copy link
Collaborator

@cmp5987 cmp5987 commented Feb 7, 2026

What type of PR is this?

/kind bug

What this PR does / why we need it:

  • Error where page re-renders when isLocked is set.
  • IsLocked shouldn't cause query rerenders

@cmp5987 cmp5987 requested a review from hulto February 7, 2026 22:49
@github-actions
Copy link
Contributor

github-actions bot commented Feb 7, 2026

Summary

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Other ❓ Flaky 🍂 Duration ⏱️
2557    ±0 2557    ±0 0    ±0 0    ±0 0    ±0 0    ±0 1ms    ±0

Previous Results

Build 🏗️ Result 🧪 Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Other ❓ Flaky 🍂 Duration ⏱️
#967 2557 2557 0 0 0 0 31.0s

Insights

Average Tests per Run Total Flaky Tests Total Failed Slowest Test (p95)
2557 0 0 5.2s

Slowest Tests

Test 📝 Results 📊 Duration (avg) ⏱️ Duration (p95) ⏱️
eldritch-libsys: std::dll_inject_impl::tests::test_dll_inject_simple 1 5.2s 5.2s
imix::bin/imix: install::tests::test_install_execution 3 1.2s 3.4s
imix::bin/imix: install::tests::test_install_execution 3 1.2s 3.4s
imix::bin/imix: install::tests::test_install_execution 3 1.2s 3.4s
imix::bin/imix: tests::task_tests::test_task_streaming_output 3 3.0s 3.0s
imix::bin/imix: tests::task_tests::test_task_streaming_output 3 3.0s 3.0s
imix::bin/imix: tests::task_tests::test_task_streaming_output 3 3.0s 3.0s
imix::bin/imix: tests::task_tests::test_task_streaming_error 3 3.0s 3.0s
imix::bin/imix: tests::task_tests::test_task_streaming_error 3 3.0s 3.0s
imix::bin/imix: tests::task_tests::test_task_streaming_error 3 3.0s 3.0s

🎉 No failed tests in this run. | 🍂 No flaky tests in this run.

Github Test Reporter by CTRF 💚

🔄 This comment has been updated

hulto
hulto previously approved these changes Feb 8, 2026
hulto
hulto previously approved these changes Feb 11, 2026
@hulto hulto added this pull request to the merge queue Feb 14, 2026
Merged via the queue into main with commit 2a0b616 Feb 14, 2026
8 checks passed
@hulto hulto deleted the ui-virtualized-table-lock-fix branch February 14, 2026 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants