Skip to content

[AI] Expand Test Coverage - eldritch/lexer#1750

Draft
KCarretto wants to merge 1 commit intomainfrom
expand-test-coverage-eldritch-lexer-12137570754510437408
Draft

[AI] Expand Test Coverage - eldritch/lexer#1750
KCarretto wants to merge 1 commit intomainfrom
expand-test-coverage-eldritch-lexer-12137570754510437408

Conversation

@KCarretto
Copy link
Collaborator

This PR expands the test coverage for the eldritch-core lexer by adding a new test file lexer_coverage.rs. It targets specific edge cases and complex behaviors identified in the codebase, such as compound assignment splitting, integer overflow, and error recovery during indentation processing.

Changes:

  • Created implants/lib/eldritch/eldritch-core/tests/lexer_coverage.rs.
  • Added tests for:
    • &=, |=, ^=, <<=, >>=, **= tokenization.
    • i64 overflow defaulting to 0.
    • Recovery from inconsistent indentation errors.
    • Prioritization of outer string errors over nested f-string errors.
    • Parsing of triple-quoted strings containing quotes.
    • Tokenization of scientific notation and trailing dots.

Verification:

  • Ran cargo test -p eldritch-core --test lexer_coverage 20 times (all passed).
  • Ran all eldritch-core tests (all passed).
  • Ran cargo fmt.

PR created automatically by Jules for task 12137570754510437408 started by @KCarretto

Added comprehensive tests for edge cases in the Eldritch Core Lexer, including:
- Compound assignment splitting (e.g., `&=`, `**=`).
- Integer overflow handling.
- Inconsistent indentation recovery.
- Nested f-string error prioritization.
- Triple-quoted strings with internal quotes.
- Scientific notation and trailing dot tokenization behavior.

These tests verify current behavior and ensure stability for complex lexing scenarios.
Verified by running the new tests 20 times without failure and ensuring no regressions in existing tests.

Co-authored-by: KCarretto <16250309+KCarretto@users.noreply.github.com>
@google-labs-jules
Copy link
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 7, 2026

Summary

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Other ❓ Flaky 🍂 Duration ⏱️
2582    ±0 2582    ±0 0    ±0 0    ±0 0    ±0 0    ±0 1ms    ±0

Previous Results

Build 🏗️ Result 🧪 Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Other ❓ Flaky 🍂 Duration ⏱️
#863 2582 2582 0 0 0 0 18.7s

Insights

Average Tests per Run Total Flaky Tests Total Failed Slowest Test (p95)
2582 0 0 5.2s

Slowest Tests

Test 📝 Results 📊 Duration (avg) ⏱️ Duration (p95) ⏱️
eldritch-libsys: std::dll_inject_impl::tests::test_dll_inject_simple 1 5.2s 5.2s
imix::bin/imix: install::tests::test_install_execution 3 1.2s 3.4s
imix::bin/imix: install::tests::test_install_execution 3 1.2s 3.4s
imix::bin/imix: install::tests::test_install_execution 3 1.2s 3.4s
imix::bin/imix: tests::task_tests::test_task_streaming_output 3 3.0s 3.0s
imix::bin/imix: tests::task_tests::test_task_streaming_output 3 3.0s 3.0s
imix::bin/imix: tests::task_tests::test_task_streaming_output 3 3.0s 3.0s
imix::bin/imix: tests::task_tests::test_task_streaming_error 3 3.0s 3.0s
imix::bin/imix: tests::task_tests::test_task_streaming_error 3 3.0s 3.0s
imix::bin/imix: tests::task_tests::test_task_streaming_error 3 3.0s 3.0s

🎉 No failed tests in this run. | 🍂 No flaky tests in this run.

Github Test Reporter by CTRF 💚

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant