Skip to content

[AI] Expand Test Coverage - eldritch-core/lexer#1718

Open
KCarretto wants to merge 2 commits intomainfrom
jules-1041214475409502697-e0ba8833
Open

[AI] Expand Test Coverage - eldritch-core/lexer#1718
KCarretto wants to merge 2 commits intomainfrom
jules-1041214475409502697-e0ba8833

Conversation

@KCarretto
Copy link
Collaborator

This PR adds a new integration test file implants/lib/eldritch/eldritch-core/tests/lexer_more_edges.rs to the eldritch-core crate. The tests target specific edge cases in the Lexer that were previously under-tested or documented only implicitly.

Key coverage areas added:

  • Integer Overflow: Verifies that integers exceeding i64::MAX are parsed as 0 (current unwrap_or(0) implementation).
  • Mixed Indentation: verifies that the lexer counts characters for indentation regardless of type (tabs vs spaces).
  • Token Separation: Confirms that sequences like + = are tokenized differently from +=.
  • Keyword Lookalikes: Ensures that identifiers starting with keywords (e.g., defe) are correctly parsed as identifiers.
  • Nested F-Strings: Tests the recursion limit and parsing of f-strings within f-strings.
  • Unicode Escapes: Documents that \uXXXX sequences are currently treated as literal characters, not unicode escapes.
  • Error Handling: verifies error tokens for unterminated strings at EOF.

These tests were run 20 times locally to ensure stability and passed successfully. Full crate tests were also run to ensure no regressions.


PR created automatically by Jules for task 1041214475409502697 started by @KCarretto

Added `implants/lib/eldritch/eldritch-core/tests/lexer_more_edges.rs` to cover:
- Integer overflow behavior (fallbacks to 0).
- Mixed indentation handling.
- Greedy tokenization of operators vs separated tokens.
- Keyword prefix identifiers (e.g. `defe`).
- Nested f-strings.
- Unicode escape sequence behavior.
- Unterminated strings at EOF.

This increases stability and documents current lexer behavior for complex edge cases.

Co-authored-by: KCarretto <16250309+KCarretto@users.noreply.github.com>
@google-labs-jules
Copy link
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 4, 2026

Summary

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Other ❓ Flaky 🍂 Duration ⏱️
2565    ±0 2565    ±0 0    ±0 0    ±0 0    ±0 0    ±0 1ms    ±0

Previous Results

Build 🏗️ Result 🧪 Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Other ❓ Flaky 🍂 Duration ⏱️
#828 2565 2565 0 0 0 0 16.9s

Insights

Average Tests per Run Total Flaky Tests Total Failed Slowest Test (p95)
2565 0 0 5.1s

Slowest Tests

Test 📝 Results 📊 Duration (avg) ⏱️ Duration (p95) ⏱️
eldritch-libsys: std::dll_inject_impl::tests::test_dll_inject_simple 1 5.1s 5.1s
imix::bin/imix: install::tests::test_install_execution 3 1.2s 3.4s
imix::bin/imix: install::tests::test_install_execution 3 1.2s 3.4s
imix::bin/imix: install::tests::test_install_execution 3 1.2s 3.4s
imix::bin/imix: tests::task_tests::test_task_streaming_output 3 3.0s 3.0s
imix::bin/imix: tests::task_tests::test_task_streaming_output 3 3.0s 3.0s
imix::bin/imix: tests::task_tests::test_task_streaming_output 3 3.0s 3.0s
imix::bin/imix: tests::task_tests::test_task_streaming_error 3 3.0s 3.0s
imix::bin/imix: tests::task_tests::test_task_streaming_error 3 3.0s 3.0s
imix::bin/imix: tests::task_tests::test_task_streaming_error 3 3.0s 3.0s

🎉 No failed tests in this run. | 🍂 No flaky tests in this run.

Github Test Reporter by CTRF 💚

🔄 This comment has been updated

@KCarretto KCarretto marked this pull request as ready for review February 6, 2026 00:29
@KCarretto KCarretto requested a review from hulto February 6, 2026 00:29
@KCarretto KCarretto enabled auto-merge February 6, 2026 00:29
@KCarretto KCarretto added this pull request to the merge queue Feb 6, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Feb 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants