Refactor Mux subscription lifecycle with ref counting #1685
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses potential race conditions and inefficient subscription management in the
Muxcomponent.Changes:
acquireSubscriptionintavern/internal/portals/mux/mux_pubsub.go: Centralizes subscription acquisition logic, including cache checking, provisioning, connection, race handling, and reference counting.CreatePortalintavern/internal/portals/mux/mux_create.go: Now usesacquireSubscriptioninstead of blindly overwriting existing subscriptions. This prevents premature closure if a subscription is already active (e.g. from a race or collision).OpenPortalintavern/internal/portals/mux/mux_open.go: Refactored to useacquireSubscriptionfor consistency and code reuse.TestMux_CreatePortal_RefCountingintavern/internal/portals/mux/mux_test.go: Verifies thatCreatePortalcorrectly initializes reference counts and that teardown respects them (subscription remains active if refs > 0).This ensures that local subscriptions are robustly managed and shared where appropriate.
PR created automatically by Jules for task 13481624774023790476 started by @KCarretto