Skip to content

Conversation

@KCarretto
Copy link
Collaborator

This PR addresses potential race conditions and inefficient subscription management in the Mux component.

Changes:

  • Added acquireSubscription in tavern/internal/portals/mux/mux_pubsub.go: Centralizes subscription acquisition logic, including cache checking, provisioning, connection, race handling, and reference counting.
  • Updated CreatePortal in tavern/internal/portals/mux/mux_create.go: Now uses acquireSubscription instead of blindly overwriting existing subscriptions. This prevents premature closure if a subscription is already active (e.g. from a race or collision).
  • Updated OpenPortal in tavern/internal/portals/mux/mux_open.go: Refactored to use acquireSubscription for consistency and code reuse.
  • Added TestMux_CreatePortal_RefCounting in tavern/internal/portals/mux/mux_test.go: Verifies that CreatePortal correctly initializes reference counts and that teardown respects them (subscription remains active if refs > 0).

This ensures that local subscriptions are robustly managed and shared where appropriate.


PR created automatically by Jules for task 13481624774023790476 started by @KCarretto

Introduced `acquireSubscription` helper to manage local subscription caching, reference counting, and race conditions. Refactored `CreatePortal` and `OpenPortal` to use this helper, ensuring subscriptions are shared and only closed when no longer in use. Added `TestMux_CreatePortal_RefCounting` to verify the fix.

Co-authored-by: KCarretto <16250309+KCarretto@users.noreply.github.com>
@google-labs-jules
Copy link
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 1, 2026

Summary

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Other ❓ Flaky 🍂 Duration ⏱️
2527    ±0 2527    ±0 0    ±0 0    ±0 0    ±0 0    ±0 1ms    ±0

Previous Results

Build 🏗️ Result 🧪 Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Other ❓ Flaky 🍂 Duration ⏱️
#717 2527 2527 0 0 0 0 18.7s

Insights

Average Tests per Run Total Flaky Tests Total Failed Slowest Test (p95)
2527 0 0 5.3s

Slowest Tests

Test 📝 Results 📊 Duration (avg) ⏱️ Duration (p95) ⏱️
eldritch-libsys: std::dll_inject_impl::tests::test_dll_inject_simple 1 5.3s 5.3s
eldritch-stdlib-tests: tests::test_all_tomes 3 5.1s 5.1s
eldritch-stdlib-tests: tests::test_all_tomes 3 5.1s 5.1s
eldritch-stdlib-tests: tests::test_all_tomes 3 5.1s 5.1s
imix::bin/imix: tests::task_tests::test_task_streaming_error 3 3.0s 3.0s
imix::bin/imix: tests::task_tests::test_task_streaming_error 3 3.0s 3.0s
imix::bin/imix: tests::task_tests::test_task_streaming_error 3 3.0s 3.0s
imix::bin/imix: tests::task_tests::test_task_streaming_output 3 3.0s 3.0s
imix::bin/imix: tests::task_tests::test_task_streaming_output 3 3.0s 3.0s
imix::bin/imix: tests::task_tests::test_task_streaming_output 3 3.0s 3.0s

🎉 No failed tests in this run. | 🍂 No flaky tests in this run.

Github Test Reporter by CTRF 💚

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant